Skip to content

fix: convert brokerId to int32 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: convert brokerId to int32 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/GetOpeningStreamsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"fields": [
{
"name": "BrokerId",
"type": "int64",
"type": "int32",
"versions": "0+",
"about": "The broker id."
},
Expand Down
4 changes: 2 additions & 2 deletions metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,8 @@ public ControllerResult<CommitStreamObjectResponseData> commitStreamObject(Commi

public ControllerResult<GetOpeningStreamsResponseData> getOpeningStreams(GetOpeningStreamsRequestData data) {
// TODO: check broker epoch, reject old epoch request.
int brokerId = (int) data.brokerId();
// The getOpeningStreams operation rate is low, so we just iterate all streams to get the broker opening streams.
int brokerId = data.brokerId();
// The getOpeningStreams is invoked when broker startup, so we just iterate all streams to get the broker opening streams.
List<StreamOffset> streamOffsets = this.streamsMetadata.entrySet().stream().filter(entry -> {
S3StreamMetadata streamMetadata = entry.getValue();
int rangeIndex = streamMetadata.currentRangeIndex.get();
Expand Down