Automatically update when a reserved keyword is used as an enum in ACT (Python bindings) #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after python binding generation is now automated inside act. The scope needs to be expanded across the script
vijaiaeroastro
changed the title
alexanderoster
approved these changes
Sep 4, 2024
gangatp
pushed a commit
that referenced
this pull request
Dec 11, 2024
…T (Python bindings) (#207) * Start with fixing the problematic enum in ACT. The current patch done after python binding generation is now automated inside act. The scope needs to be expanded across the script * Extend the reserved keyword check across the entire Python binding
gangatp
pushed a commit
that referenced
this pull request
Dec 16, 2024
…T (Python bindings) (#207) * Start with fixing the problematic enum in ACT. The current patch done after python binding generation is now automated inside act. The scope needs to be expanded across the script * Extend the reserved keyword check across the entire Python binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch maintains a dictionary of Python keywords, which can be obtained using the following code:
This patch warns the user and automatically changes the enum LHS to enum_name + enum_option_name. It fixes the issue (#145) in lib3mf immediately. The scope of this needs to be expanded to the rest of the code. I believe it is even better to check the XML file at the beginning and produce a modified XML file to avoid any changes to ACT code. That would be a more feasible option. Feedback is welcome.