-
Notifications
You must be signed in to change notification settings - Fork 60
Store Protected Zones in Devtools [AARD-2064]
#1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AlexD717
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
azaleacolburn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by some of the things you're doing, both with how they relate to this PR and why we would want to do them in general.
|
The answer to both of those comments is that they are to allow you to access helpful information from the browser devtools, which famously cannot import synthesis/fission/src/systems/World.ts Lines 90 to 92 in d9474b2
|
BrandonPacewic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is 3rd in que.
* 'dev' of github.com:Autodesk/synthesis: feat: hide unused wheeltypes feat: hide material tagging UI and mix and match toggle fix: run formatter Update fission/src/mirabuf/MirabufSceneObject.ts Update fission/src/ui/panels/configuring/assembly-config/configure/AssemblySelection.tsx fix: make configure asset panel react to configuration changes and robot removals
Task
AARD-2064
Symptom
Currently protected zones, which are a field specific property, aren't stored in the mirabuf file via developer tools and have to be configured by each user
Solution
Added protected zones to the developer tools menu to allow them to be persisted into the mirabuf data
Verification
bun run assetpackFRC Field 2023_v7.miraBefore merging, ensure the following criteria are met: