Skip to content

Conversation

@rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 15, 2025

Task

AARD-2064

Symptom

Currently protected zones, which are a field specific property, aren't stored in the mirabuf file via developer tools and have to be configured by each user

Solution

Added protected zones to the developer tools menu to allow them to be persisted into the mirabuf data

Verification

  1. bun run assetpack
  2. Open synthesis, clear your preferences, and import FRC Field 2023_v7.mira
  3. Observe that scoring zones and protected zones are already configured
  4. Drive around in match mode to confirm that they actually work properly

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz self-assigned this Aug 15, 2025
@rutmanz rutmanz requested review from a team as code owners August 15, 2025 00:25
@rutmanz rutmanz added the gameplay Relating to the playability of Synthesis label Aug 15, 2025
Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by some of the things you're doing, both with how they relate to this PR and why we would want to do them in general.

@rutmanz
Copy link
Member Author

rutmanz commented Aug 21, 2025

The answer to both of those comments is that they are to allow you to access helpful information from the browser devtools, which famously cannot import World or THREE.Vector3. The reason it's part of this PR is that it can be quite useful when trying to get positioning information when configuring predefined zones (I found myself wanting it when defining the 2023 field zones).

if (import.meta.env.DEV) {
window.World = World
}

@rutmanz rutmanz requested a review from azaleacolburn August 21, 2025 17:16
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is 3rd in que.

@BrandonPacewic BrandonPacewic mentioned this pull request Aug 21, 2025
* 'dev' of github.com:Autodesk/synthesis:
  feat: hide unused wheeltypes
  feat: hide material tagging UI and mix and match toggle
  fix: run formatter
  Update fission/src/mirabuf/MirabufSceneObject.ts
  Update fission/src/ui/panels/configuring/assembly-config/configure/AssemblySelection.tsx
  fix: make configure asset panel react to configuration changes and robot removals
@BrandonPacewic BrandonPacewic merged commit e365104 into dev Aug 21, 2025
16 checks passed
@BrandonPacewic BrandonPacewic deleted the zachr/2064/protected-zone-devtools branch August 21, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gameplay Relating to the playability of Synthesis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants