-
Notifications
You must be signed in to change notification settings - Fork 60
Dropdown Sounds Reimplemented [AARD-2065]
#1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+64
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
requested changes
Aug 19, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The dropdown sound is a bit loud compared to the button sound
- I'm not sure if this is within the scope of the PR, but the accordions in the Spawn Robots panel don't make noise when interacted with.
azaleacolburn
approved these changes
Aug 19, 2025
ryanzhangofficial
approved these changes
Aug 20, 2025
Member
ryanzhangofficial
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great!
PepperLola
reviewed
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Reimplement Dropdown Sounds
AARD-2065
Symptom
UI refactor broke dropdown sounds, which is not good.
Solution
Verification
Opening and closing dropdowns plays a sfx. (Example dropdown can be found in protected zone config)
Opening and closing accordions plays a sfx. (Spawn asset panel)
Before merging, ensure the following criteria are met: