Skip to content

Conversation

@AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Aug 18, 2025

Task

Reimplement Dropdown Sounds

AARD-2065

Symptom

UI refactor broke dropdown sounds, which is not good.

Solution

  • Wrap the select mui component to make it so that any dropdown object would automatically play sounds.
  • Also wrap the accordion component (in spawn asset panel)
  • Make the dropdown sfx quieter

Verification

Opening and closing dropdowns plays a sfx. (Example dropdown can be found in protected zone config)
Opening and closing accordions plays a sfx. (Spawn asset panel)


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 18, 2025
@AlexD717 AlexD717 marked this pull request as ready for review August 18, 2025 20:52
@AlexD717 AlexD717 requested review from a team as code owners August 18, 2025 20:52
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The dropdown sound is a bit loud compared to the button sound
  • I'm not sure if this is within the scope of the PR, but the accordions in the Spawn Robots panel don't make noise when interacted with.

@AlexD717 AlexD717 requested a review from azaleacolburn August 19, 2025 18:06
Copy link
Member

@ryanzhangofficial ryanzhangofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@AlexD717 AlexD717 requested a review from PepperLola August 22, 2025 17:53
@PepperLola PepperLola merged commit b6a6caf into dev Aug 23, 2025
17 checks passed
@PepperLola PepperLola deleted the alexey/2065/dropdown-sounds-reimplement branch August 23, 2025 00:40
@PepperLola PepperLola mentioned this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants