Turn Off Biome Import Sorting [AARD-2096]
#1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
requested review from
AlexD717,
BrandonPacewic,
PepperLola and
itspvty
azaleacolburn
added
the
development
rutmanz
approved these changes
Aug 20, 2025
azaleacolburn
force-pushed
the
colbura/2096/tweak-biome
branch
from
7ade23e to
b29d83b
Compare
itspvty
approved these changes
Aug 21, 2025
AlexD717
approved these changes
Aug 21, 2025
ryanzhangofficial
approved these changes
Aug 21, 2025
BrandonPacewic
approved these changes
Aug 21, 2025
Member
BrandonPacewic
left a comment
BrandonPacewic
left a comment
There was a problem hiding this comment.
This pull request is first in que.
* 'dev' of github.com:Autodesk/synthesis: fix: make returns consistent fix: make the test match id not overlap with unit tests feat: update assetpack feat: load match mode configs from manifest file instead feat: hide unused wheeltypes feat: hide material tagging UI and mix and match toggle feat: store protected zones in devtools and configure the 2023 field fix: run formatter Update fission/src/mirabuf/MirabufSceneObject.ts Update fission/src/ui/panels/configuring/assembly-config/configure/AssemblySelection.tsx fix: make configure asset panel react to configuration changes and robot removals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-2096
Symptom
Previously we were using
bun run stylefor checking which ranbiome formatandbiome lint, neither of which sorted imports.biome checkon the other hand, runs both commands and checks if the imports are sorted.Sorting imports is not desired, as it makes diffs unnecessarily large for minimal hygenic and aesthetic benefit, but calling two commands when there exists one that already calls both isn't either.
Solution
Switch
bun run styleto usebiome checkand biome no longer sorts imports.Verification
bun run style:fix(orbiome check --fix) and observe that they have not been reordered.Before merging, ensure the following criteria are met: