Fix View Cube Snapping [AARD-2098]
#1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Fix the view cube face/edge/vertex snapping.
AARD-2098
Symptom
Pressing on the face/edge/vertex of the view cube does not snap to that view.
Solution
Instead of using handleMouseUp use handleGlobalMouseUp, as pointer lock breaks handleMouseUp. Also record position traveled, rather than looking at distance from start point as pointer lock again breaks that.
Verification
Pressing on the faces/edges/vertexes moves the camera to the appropriate angle. You can still press and drag the view cube as normal. If you dragged the cursor more than 10 pixels, it doesn't snap to the face/edge/vertex.
Before merging, ensure the following criteria are met: