Skip to content

Conversation

@AlexD717
Copy link
Member

Task

Fix the view cube face/edge/vertex snapping.

AARD-2098

Symptom

Pressing on the face/edge/vertex of the view cube does not snap to that view.

Solution

Instead of using handleMouseUp use handleGlobalMouseUp, as pointer lock breaks handleMouseUp. Also record position traveled, rather than looking at distance from start point as pointer lock again breaks that.

Verification

Pressing on the faces/edges/vertexes moves the camera to the appropriate angle. You can still press and drag the view cube as normal. If you dragged the cursor more than 10 pixels, it doesn't snap to the face/edge/vertex.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 20, 2025
@AlexD717 AlexD717 added the bug label Aug 20, 2025
@AlexD717 AlexD717 marked this pull request as ready for review August 20, 2025 20:36
@AlexD717 AlexD717 requested review from a team as code owners August 20, 2025 20:36
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! this was bugging me

Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola PepperLola merged commit 1059bbd into dev Aug 22, 2025
17 checks passed
@PepperLola PepperLola mentioned this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants