Skip to content

Conversation

@rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 21, 2025

Task

AARD-2086

Symptom

Currently default match mode configs are defined in-code, which means that updating the list (as would be necessary on kickoff) would require a redeploy of synthesis

Solution

This changes them to be defined by a JSON file in the assetpack, which is loaded on startup

Verification

Check that the configurations still show up and work correctly
This does change the assetpack, so you'll have to run bun run assetpack before testing


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz requested review from a team as code owners August 21, 2025 15:54
@rutmanz rutmanz marked this pull request as draft August 21, 2025 15:54
@rutmanz rutmanz self-assigned this Aug 21, 2025
@rutmanz rutmanz added gameplay Relating to the playability of Synthesis refactor The most important part of software development. labels Aug 21, 2025
@rutmanz rutmanz marked this pull request as ready for review August 21, 2025 16:03
@rutmanz rutmanz changed the title feat: load match mode configs from manifest file instead Use JSON file for match mode configs [AARD-2086] Aug 21, 2025
Copy link
Member

@ryanzhangofficial ryanzhangofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a very small nitpick

@BrandonPacewic BrandonPacewic mentioned this pull request Aug 21, 2025
@BrandonPacewic BrandonPacewic merged commit 27a46c2 into dev Aug 21, 2025
16 checks passed
@BrandonPacewic BrandonPacewic deleted the zachr/2086/matchmode-configs branch August 21, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gameplay Relating to the playability of Synthesis refactor The most important part of software development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants