Mirabuf Parser Testing [AARD-1939]
#1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
force-pushed
the
colbura/1939/mirabuf-parser-testing
branch
from
607c308 to
5aa41f7
Compare
azaleacolburn
requested review from
BrandonPacewic,
Dhruv-0-Arora,
PepperLola and
rutmanz
ryanzhangofficial
approved these changes
Aug 21, 2025
Member
ryanzhangofficial
left a comment
ryanzhangofficial
left a comment
There was a problem hiding this comment.
Overall, really clean tests! I just noticed a few stray comment markers that I think you didn't mean to keep.
rutmanz
reviewed
Aug 21, 2025
azaleacolburn
changed the title
[AARD-1939]
azaleacolburn
force-pushed
the
colbura/1939/mirabuf-parser-testing
branch
6 times, most recently
from
a93e6a9 to
62ca1b6
Compare
azaleacolburn
force-pushed
the
colbura/1939/mirabuf-parser-testing
branch
from
b3ef583 to
f4d865d
Compare
rutmanz
approved these changes
Aug 22, 2025
* 'dev' of github.com:Autodesk/synthesis: (161 commits) fix: final readme fixes fix: remove commited config file fix: migrate biome config fix: remove prints fix: formatter and new SoundPlayer singleton fix: typing fix: focus and configuration fixes fix: format and lint fix: renamed field asset in test fix: tests pass now fix: ui appearance changes - updated main hud with new buttons, made button group - made modal colors consistent with panel - switched to using tabs instead of toggle button groups - fixed aps reload button disappearing on import panel reopen Scrollable Command Palette fix: make ci work No radius in text field top edges Disable Autocomplete Update README.md docs: move contributing section in README.md to CONTRIBUTING.md fix: make robots reset to spawn positions in multiplayer Removed Useless Command & Black Border Register Commands Formatting ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-1939
Symptom
Previously, the MirabufParser tests only counted rigid nodes rather than testing the full parser, the additional validation they performed was on the assembly, rather than the returned parser.
Solution
The new tests check the parser's
globalTransforms,partTreeValues,partToNodeMap, and rigid nodes. In the case of larger assemblies (eg. fields) where checking every value in the transform would be unwieldy, the sum of the transforms is checked instead.Verification
The rewritten tests pass
Before merging, ensure the following criteria are met: