Skip to content

CI Fix #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

CI Fix #1294

merged 1 commit into from
Aug 22, 2025

Conversation

@rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 22, 2025

Task

AARD-

Symptom

CI checks not failing when the tests fail due to probably a playwright bug. This forces them to exit with code 1 if a test fails

Solution

Verification

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz requested review from a team as code owners August 22, 2025 19:29
azaleacolburn
azaleacolburn reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume we want a separate PR to fix the failing tests?

@rutmanz
Copy link
Member Author

rutmanz commented Aug 22, 2025

it could (maybe should) be part of this one, feel free to push if you have time (I'm fixing multiplayer stuff

PepperLola
PepperLola approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can fix the failing tests in another PR

@PepperLola PepperLola merged commit 29db391 into dev Aug 22, 2025
16 of 17 checks passed
@PepperLola PepperLola deleted the zachr/fix-ci branch August 22, 2025 22:13
@PepperLola PepperLola mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PepperLola PepperLola PepperLola approved these changes

@itspvty itspvty Awaiting requested review from itspvty itspvty is a code owner automatically assigned from Autodesk/fission

@AlexD717 AlexD717 Awaiting requested review from AlexD717 AlexD717 is a code owner automatically assigned from Autodesk/fission

@BrandonPacewic BrandonPacewic Awaiting requested review from BrandonPacewic BrandonPacewic is a code owner automatically assigned from Autodesk/synthesis-admin

@azaleacolburn azaleacolburn Awaiting requested review from azaleacolburn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rutmanz @PepperLola @azaleacolburn