Skip to content

Multiplayer Fixes [AARD-2105] #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2025
Merged

Multiplayer Fixes [AARD-2105] #1296

merged 4 commits into from
Aug 23, 2025

Conversation

@rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 23, 2025 •
edited
Loading

Task

AARD-2105

Symptom

  • Configs don't sync consistently
  • Focus is transferred to enemy robots

Solution

Verification

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz requested review from a team as code owners August 23, 2025 00:24
PepperLola
PepperLola approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, config syncing works. It doesn't communicate the alliance to the other client initially but re-configuring it syncs it between them.

@PepperLola PepperLola merged commit 68c19e6 into dev Aug 23, 2025
17 checks passed
@PepperLola PepperLola deleted the zachr/2105/multiplayer-bugfix branch August 23, 2025 00:36
@PepperLola PepperLola mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PepperLola PepperLola PepperLola approved these changes

@azaleacolburn azaleacolburn Awaiting requested review from azaleacolburn azaleacolburn is a code owner automatically assigned from Autodesk/fission

@ryanzhangofficial ryanzhangofficial Awaiting requested review from ryanzhangofficial ryanzhangofficial is a code owner automatically assigned from Autodesk/fission

@BrandonPacewic BrandonPacewic Awaiting requested review from BrandonPacewic BrandonPacewic is a code owner automatically assigned from Autodesk/synthesis-admin

Assignees

@rutmanz rutmanz

Labels

multiplayer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rutmanz @PepperLola