Skip to content

Added App to WebSection #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Added App to WebSection #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8f6331
added app to WebSection
teo-nikolov Feb 15, 2024
db46175
depricate browser() and create() in favour if app()
teo-nikolov Feb 15, 2024
e4a0345
fixes for PR comments
teo-nikolov Jan 13, 2025
5b20329
deprecated browser and create in WebPage in favour of app
teo-nikolov Jan 13, 2025
e760877
removed @Deprecated annotation and updated browser and create methods
teo-nikolov Jan 13, 2025
a317275
Merge remote-tracking branch 'origin/main' into feature-update-websec…
teo-nikolov Jan 13, 2025
7689af7
fixed build errors and added javaScript to WebSection
teo-nikolov Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bellatrix.web/src/main/java/solutions/bellatrix/web/pages/WebPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@

public abstract class WebPage<MapT extends PageMap, AssertsT extends PageAsserts<MapT>> {
public BrowserService browser() {
return new BrowserService();
return app().browser();
}

public JavaScriptService javaScript() {
return new JavaScriptService();
public ComponentCreateService create() {
return app().create();
}

public ComponentCreateService create() {
return new ComponentCreateService();
public JavaScriptService javaScript() {
return app().script();
}

public App app() {
Expand Down
14 changes: 12 additions & 2 deletions bellatrix.web/src/main/java/solutions/bellatrix/web/pages/WebSection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,28 @@

package solutions.bellatrix.web.pages;

import solutions.bellatrix.web.services.App;
import solutions.bellatrix.web.services.BrowserService;
import solutions.bellatrix.web.services.ComponentCreateService;
import solutions.bellatrix.web.services.JavaScriptService;

import java.lang.reflect.ParameterizedType;

public abstract class WebSection<MapT extends PageMap, AssertionsT extends PageAsserts<MapT>> {
public BrowserService browser() {
return new BrowserService();
return app().browser();
}

public ComponentCreateService create() {
return new ComponentCreateService();
return app().create();
}

public JavaScriptService javaScript() {
return app().script();
}

public App app() {
return new App();
}

public MapT map() {
Expand Down
Loading