Automatic Browser Shutdown Update #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its purpose is to register Runnable script to be performed after shutdown is initiated. Notable uses would be to register for closure resources that should be closed.
They are no longer static and register themselves for automatic closure after shutdown.
This reverts commit 21006b2.
n1xan
approved these changes
Jul 18, 2024
Made one of the threadlocal variables with initial instead of initializing them in the constructor of BaseTest, as problems occur during parallel execution otherwise
n1xan
reviewed
Jan 15, 2025
| "webSettings": { | ||
| "baseUrl": "http://demos.bellatrix.solutions/", | ||
| "executionType":"regular", | ||
| "executionType":"regular", |
n1xan
reviewed
Jan 15, 2025
| "webSettings": { | ||
| "baseUrl": "http://demos.bellatrix.solutions/", | ||
| "executionType":"regular", | ||
| "executionType":"regular", |
Collaborator
Author
There was a problem hiding this comment.
Not an intended change, but a result of this commit: 7c02244
Since then, the added option in that commit was removed and this is what remained.
Reverted.
n1xan
reviewed
Jan 15, 2025
bellatrix.core/src/main/java/solutions/bellatrix/core/utilities/SingletonFactory.java
Show resolved
Hide resolved
Collaborator
|
Please add description with the problems you are trying to solve with the PR and which projects does it affect e.g. Playwright/Selenium? |
n1xan
reviewed
Jan 22, 2025
| // launchOptions.setArgs(List.of("--log-level=3")); | ||
| // System.setProperty("webdriver.chrome.silentOutput", "true"); ? | ||
|
|
||
| return browser(browserType.launch(launchOptions)); |
Collaborator
There was a problem hiding this comment.
The formatting is a bit messed up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drivers and browsers are now correctly disposed of when test execution is abruptly interrupted, such as during debugging, manual termination, or browser closure failure.
Changes affect Selenium and Playwright modules.