Bellatrix OpenCV ActionImage Update #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1xan
reviewed
Nov 27, 2024
Collaborator
n1xan
left a comment
n1xan
left a comment
There was a problem hiding this comment.
For now I think it is okay, but we have to think whether this approach i applicable in mobile and desktop tests as well, which means we will have to move this to a separate module, or apply the component to the other modules as well,
n1xan
reviewed
Nov 27, 2024
|
|
||
| public String toString() { | ||
| return "By.imageBase64: " + this.base64EncodedImage; | ||
| } |
Collaborator
There was a problem hiding this comment.
I am thinking of renaming the class to ByImage, which has overloads for base64 string, and also file path.
Collaborator
There was a problem hiding this comment.
Another option is to create it as a separate class
n1xan
approved these changes
Nov 27, 2024
… in SingletonFactory
It is not supposed to be used outside of the context of ImageBase64FindStrategy; furthermore, it has no place in 'infrastructure' folder
…iver They were using a driver saved in a private field, which could be closed any time during the test execution, resulting in an exception. This change makes it possible for the services to be safely retrieved from SingletonFactory.
…ctory in App Instead of creating each time a new instance of them and returning it.
…nshot plugin couldn't be found
…ate' into bellatrix-opencv-actionimage-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.