QuickEditor: Handle CAMERA permission #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
Bug
AdamGrzybkowski
commented
Oct 16, 2024
| <string name="oauth_email_associated_error_message">Something went wrong when verifying your email.</string> | ||
| <string name="gravatar_qe_permission_required_alert_title">Permission required</string> | ||
| <string name="gravatar_qe_camera_permission_rationale_message">To take a picture, you need to grant camera permission. You can grant it in the app settings.</string> | ||
| <string name="gravatar_qe_dismiss">Dismiss</string> |
Contributor
Author
There was a problem hiding this comment.
@mlumeau We will have to wait for the translations.
Collaborator
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/393_camera_permission
branch
from
4c8e89d to
058390b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #393
Description
It turns out we need to handle the Camera permission when a third-party app has
<uses-permission android:name="android.permission.CAMERA" />defined in itsAndroidManifest.xml. If we don't we will getSecurityExceptionwhen launching theACTION_IMAGE_CAPTUREintent - source.Permission granted
https://github.com/user-attachments/assets/55dd6c8e-100d-4145-9d59-d88112d9efd8
Permission denied
https://github.com/user-attachments/assets/c5062aa4-25a7-47ca-9c36-dfe42f04b14c
No permission in the third-party app
https://github.com/user-attachments/assets/e742f451-c297-431a-98ff-7ddc9b7651ca
Testing Steps
Camera permission is commented out in the Demo app manifest