-
Notifications
You must be signed in to change notification settings - Fork 47
QuickEditor: Implement GravatarQuickEditorActivity #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
Collaborator
Project dependencies changesThe following changes in project dependencies were detected (configuration listtree-\--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03
- \--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03
- \--- io.github.osipxd:encrypted-datastore:1.1.1-beta03
- \--- androidx.datastore:datastore-core:1.1.1
- \--- androidx.datastore:datastore-core-android:1.1.1
- \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22
- +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.10 (*)
- \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.22
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.10 (*)
++--- project :gravatar
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.10 (*)
+| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.9.25
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.10 (*)
++--- io.github.osipxd:security-crypto-datastore-preferences:1.1.1-beta03
+| \--- io.github.osipxd:encrypted-datastore-preferences:1.1.1-beta03
+| \--- io.github.osipxd:encrypted-datastore:1.1.1-beta03
+| \--- androidx.datastore:datastore-core:1.1.1
+| \--- androidx.datastore:datastore-core-android:1.1.1
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 1.9.25 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 (*) |
65f7251 to
f8a2614
Compare
ffe9d0a to
2090953
Compare
AdamGrzybkowski
approved these changes
Nov 13, 2024
Contributor
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🎉
I tested it with: Opera, Chrome, Firefox, DuckDuckGo, and Brave. All worked fine.
Left some minor comments, but the functionality itself is 🟢
gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/GravatarQuickEditorActivity.kt
Outdated
Show resolved
Hide resolved
To simplify the integration we need to remove the limitation of using the QuickEditor from an activity using the launchMode="singleTask". The approach is to create an intermediate activity that can assume the complexity and the launch mode required by the QE. The behavior should be as much as possible as it is using the Composable directly. In this commit, we are losing the "callback" part, so the app can't notice when the QE is closed or when the avatar changes. We'll need to add some ways to inform you about those events. # Conflicts: # gravatar-quickeditor/build.gradle.kts # gravatar/build.gradle.kts
5679f87 to
be1e107
Compare
be1e107 to
40f7500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
Description
To simplify the integration we need to remove the limitation of using the QuickEditor from an activity using the launchMode="singleTask".
The approach is to create an intermediate activity that can assume the complexity and the launch mode required by the QE. The behavior should be as much as possible as it is using the Composable directly.
Kapture.2024-11-13.at.15.31.45.mp4
Testing Steps
demo-appmanifest uncomment theGravatar QE Activitypart and comment the intent filter inMainActivity(or apply this patch)demo-appTest with Activity without ComposeUpdate Avatar with QuickEditor Activity