RestrictedFunctionsSniff: Add add_site_option function to site_option

[rebeccahum]

Fixes #370.

[GaryJones]

Should this be added to the WordPressVIPMinimum ruleset test, to check that it does through a warning for that ruleset?

[rebeccahum]

I don't think so because that grouping of rules isn't explicitly listed in the WordPressVIPMinimum ruleset.

[GaryJones]

I don't think so because that grouping of rules isn't explicitly listed in the WordPressVIPMinimum ruleset.

They may be implicitly included by virtue of the whole directory of sniffs being included, but that doesn't mean we shouldn't be testing for them. There are plenty of // WordPressVIPMinimum. instances in the ruleset test, including a whole block for RestrictedFunctions; though it looks incomplete, any new additions should be added anyway IMO.

[rebeccahum]

If we are going to test for them, we should test for all being implicitly included and re-work the WordPressVIPMinimum integration tests to account for that in a different PR.

[GaryJones]

If we are going to test for them, we should test for all being implicitly included and re-work the WordPressVIPMinimum integration tests to account for that in a different PR.

Right - the ruleset test needs updating in another PR, but the bit relevant to this PR should be added in this PR - think atomic commits / merges.

[rebeccahum]

Fair enough, done!

[GaryJones]

PHPCS Audit has been updated.