EscapingVoidReturnFunctions: Fix docs and logic #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
requested changes
Mar 4, 2019
Contributor
rebeccahum
left a comment
rebeccahum
left a comment
There was a problem hiding this comment.
Hiya! Let's fix the TravisCI error before proceeding:
FILE: WordPressVIPMinimum/Sniffs/Security/EscapingVoidReturnFunctionsSniff.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
17 | ERROR | Doc comment long description must start with a capital letter
| | (Generic.Commenting.DocComment.LongNotCapital)
- Use the parent `$printingFunctions` list of printing functions, instead of just checking for `_e` and `_ex`. - Fix the class description. - Add ruleset tests for both standards. Fixes #387.
GaryJones
force-pushed
the
feature/387-escapingvoidreturnfunctions
branch
from
ca9b4b8 to
402ac50
Compare
Contributor
Author
|
Fixed! |
rebeccahum
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$printingFunctionslist of printing functions, insteadof just checking for
_eand_ex.Fixes #387.