Instant Search: Add sidebar filters support #13195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing results yet. Lots of linter errors.
…te changes not triggering re-render though.
gibrown
added
[Type] Enhancement
gibrown
commented
Aug 6, 2019
| filterName={ filterName } | ||
| title={ filter.name } | ||
| type={ filter.type } | ||
| results={ self.state.results } |
There was a problem hiding this comment.
@jsnmoon or @bluefuton this is the place where re-rendering when the results state changes is not working.
This is an automated check which relies on |
|
This work is being continued in #13332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only affects the instant search prototype. Adds the aggregations to the api call based on the widget(s) configs and then renders the results.