Add rudimentary support for filtering on post types #13430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Just a drive by-comment, but to save on the bundle size, it might make sense to rely on external @wordpress/url
jsnmoon
force-pushed
the
add/instant-search-filtered-results-handling
branch
from
520c330 to
017e3d5
Compare
jsnmoon
added
[Status] Needs Review
…-results-handling
gibrown
approved these changes
Sep 9, 2019
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
jsnmoon
added a commit
that referenced
this pull request
Oct 23, 2019
* Implement minimal search results and spelling correction (#13365) * Add filtering display (#13371) * Fix search result display bugs and make improvements (#13393) * Add rudimentary support for filtering on post types (#13430) * Add support for filtering on categories and tags (#13505) * Add instant search sorting based on the URL (#13377) * Add support for filtering on dates (#13545) * Add custom taxonomy filtering (#13605) * add sort widget (#13614) * fix many theme incompatibilities (#13602) * Add infinite scrolling (#13684) * Add caching to the api requests (#13714) * Clean up some design bugs/issues (#13721) * Fix labels for post types when we have them. (#13750) * Add localization and formatting of all dates (#13748) * search from any page on the site (#13713) * Hook up default options (inc. sort) (#13742) * Add TrainTracks analytics (#13730) * Create PostTypeIcon component (#13790) * Upgrade to Preact 10 (#13794) * Add comments component (#13797) * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This enables filtering search results by post types checkboxes.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Yes, this adds post type filtering to a yet unreleased Instant Search.
Testing instructions:
define( "JETPACK_SEARCH_PROTOTYPE", true );to your wp-config.php./?s=privacy.Proposed changelog entry for your changes:
None necessary.