-
Notifications
You must be signed in to change notification settings - Fork 834
Instant Search: Add infinite scrolling #13684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bf5c275
Initial working version of infinite scroll
gibrown 697e1c0
Initial working version of infinite scroll, part 2
12fd58f
Add scroll check for infinite scrolling experience
6ca9095
Shorten load button copy
440805b
Rename onClick to onLoadNextPage
a0f724c
Fix discrepancies from rebase
4577049
Rename enableAutoScrolling to enableLoadOnScroll
f3fd552
Fix discrepancies from rebase
5013e38
Pass response along as a property
3369929
Fix discrepancies from rebase
f994f87
Enable aggregations for non-paged requests
450f42f
Preserve aggregations for paged response
f310deb
Fix pagination bug
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
modules/search/instant-search/components/scroll-button.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/** @jsx h */ | ||
|
||
/** | ||
* External dependencies | ||
*/ | ||
import { h, Component } from 'preact'; | ||
import { __ } from '@wordpress/i18n'; | ||
// NOTE: We only import the debounce package here for to reduced bundle size. | ||
// Do not import the entire lodash library! | ||
// eslint-disable-next-line lodash/import-scope | ||
import debounce from 'lodash/debounce'; | ||
|
||
class ScrollButton extends Component { | ||
componentDidMount() { | ||
this.props.enableLoadOnScroll && document.addEventListener( 'scroll', this.checkScroll ); | ||
} | ||
componentDidUnmount() { | ||
document.removeEventListener( 'scroll', this.checkScroll ); | ||
} | ||
|
||
checkScroll = debounce( () => { | ||
if ( | ||
this.props.enableLoadOnScroll && | ||
window.innerHeight + window.scrollY === document.body.offsetHeight | ||
) { | ||
this.props.onLoadNextPage(); | ||
} | ||
}, 100 ); | ||
|
||
render() { | ||
return ( | ||
<button | ||
className="jetpack-instant-search__scroll-button" | ||
disabled={ this.props.isLoading } | ||
onClick={ this.props.onLoadNextPage } | ||
> | ||
{ this.props.isLoading ? ( | ||
<span>{ __( 'Loading…', 'jetpack' ) }</span> | ||
) : ( | ||
<span>{ __( 'Load more', 'jetpack' ) }</span> | ||
) } | ||
</button> | ||
); | ||
} | ||
} | ||
|
||
export default ScrollButton; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.