Skip to content

Conversation

miguelxpn
Copy link
Contributor

@miguelxpn miguelxpn commented Oct 6, 2021

Changes proposed in this Pull Request:

  • Removed old obsolete hotfixes

Jetpack product discussion

  • Internal reference: p3btAN-1xz-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Activate VaultPress and make sure that no error pops up.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Vaultpress plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 6, 2021
@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Type] Janitorial and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 6, 2021
@jeherve jeherve added this to the vaultpress/2.2 milestone Oct 6, 2021
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It's always good to see so much red in a diff :)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 6, 2021
@jeherve jeherve enabled auto-merge (squash) October 6, 2021 16:44
@jeherve jeherve merged commit 2836f41 into master Oct 6, 2021
@jeherve jeherve deleted the vaultpress/remove-obsolete-hotfixes branch October 6, 2021 16:59
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants