Skip to content

Publicize: do not disable toggle connection control when RePublicize is enabled #21373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2021
Merged

Publicize: do not disable toggle connection control when RePublicize is enabled #21373

merged 5 commits into from
Oct 19, 2021

Conversation

retrofox
Copy link
Contributor

Branched off from #21368

This PR adds changes that don't disable the connection toggle controls when the post has been shared when RePublicize is enabled.
Currently, once the post shares it isn't possible to do it again. That's Publicize feature.
But when RePublicize is enabled it doesn't make sense to disable the connection even when the post has been shared, because that's RePublicize feature: Sharing again and again.

Fixes #

Changes proposed in this Pull Request:

  • Publicize: do not disable toggle connection control when RePublicize is enabled

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Create a new post
  • Add social media connections
  • Share the post
  • Disable the RePublicize feature (issue with instructions)
  • Confirm when RePublicize is disabled, the connection toggle is disabled

Above, I've shared the post with the @retrofoxonfire twitter account.

  • Enable RePublicize feature
  • Confirm you still can toggle the connection.

@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. [Extension] Publicize Block editor plugin labels Oct 12, 2021
@retrofox retrofox requested a review from a team October 12, 2021 12:19
@retrofox retrofox self-assigned this Oct 12, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D68272-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@retrofox retrofox mentioned this pull request Oct 12, 2021
Closed
8 tasks
@github-actions github-actions bot added [Block] Gathering Tweetstorms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

@retrofox retrofox changed the title * Publicize: do not disable toggle connection control when RePublicize is enabled Publicize: do not disable toggle connection control when RePublicize is enabled Oct 12, 2021
@retrofox retrofox mentioned this pull request Oct 12, 2021
Merged
@retrofox retrofox force-pushed the update/publicize-do-not-disable-toggle-connection-control branch 2 times, most recently from 430dd4e to 3d9bbeb Compare October 14, 2021 19:59
@retrofox retrofox mentioned this pull request Oct 15, 2021
Merged
@retrofox retrofox force-pushed the update/publicize-do-not-disable-toggle-connection-control branch 2 times, most recently from cc2ae95 to b7d2fd7 Compare October 15, 2021 14:07
@retrofox
Copy link
Contributor Author

This is looking good. As mentioned in Slack, it would be good if:
New post / Sharing disabled / Connections available
Published post / Sharing disabled / connections available
Had the full section fade out that's in the updated designs, but that can be another PR if it's easier

@pablinos can you define with more detail these variations, please?

@retrofox retrofox force-pushed the update/publicize-do-not-disable-toggle-connection-control branch 2 times, most recently from 630d336 to 1cc2891 Compare October 18, 2021 18:37
@retrofox retrofox force-pushed the update/publicize-do-not-disable-toggle-connection-control branch from 1cc2891 to cd5f134 Compare October 18, 2021 21:14
DustyReagan
DustyReagan approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as expected. LGTM! 👍

@DustyReagan DustyReagan added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Oct 18, 2021
@retrofox retrofox requested a review from a team October 18, 2021 23:38
@pablinos
Copy link
Contributor

can you define with more detail these variations, please?

Sorry I was referring to the titles of the screenshots in #21368

New post / Sharing disabled / Connections available

New post / Sharing disabled / Connections available

Published post / Sharing disabled / connections available

Published post / Sharing disabled / connections available

@jeherve jeherve added this to the jetpack/10.3 milestone Oct 19, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 19, 2021
@jeherve jeherve merged commit 7b39bee into master Oct 19, 2021
@jeherve jeherve deleted the update/publicize-do-not-disable-toggle-connection-control branch October 19, 2021 08:03
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 19, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D68272-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

davidlonjon added a commit that referenced this pull request Oct 19, 2021
@davidlonjon
Merge branch 'master' into fix/boost-ui-issues
d49dcac 
* master:
  Releases: start 10.3-a.4 cycle (#21454)
  Atomic Release: prepare changelogs for today's release (#21453)
  Connection: fixing the bug with connect button not appearing for secondary users (#21450)
  CLI: Add readme to 'jetpack release' (#21418)
  Update handling and setting CCPA related cookies (#21337)
  Publicize: do not disable toggle connection control when RePublicize is enabled (#21373)
  External Media: Add bottom padding to Google Photos modal (#21201)
  Blog Subscription Widget: deprecate widget and transform to block (#21184)
davidlonjon added a commit that referenced this pull request Oct 19, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
4489562 
# By Jeremy Herve (2) and others
# Via GitHub
* master:
  Releases: start 10.3-a.4 cycle (#21454)
  Atomic Release: prepare changelogs for today's release (#21453)
  Connection: fixing the bug with connect button not appearing for secondary users (#21450)
  CLI: Add readme to 'jetpack release' (#21418)
  Update handling and setting CCPA related cookies (#21337)
  Publicize: do not disable toggle connection control when RePublicize is enabled (#21373)
  External Media: Add bottom padding to Google Photos modal (#21201)
  Blog Subscription Widget: deprecate widget and transform to block (#21184)

# Conflicts:
#	projects/plugins/boost/tests/e2e/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

+1 more reviewer

@DustyReagan DustyReagan DustyReagan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@retrofox retrofox

Labels
[Block] Gathering Tweetstorms [Extension] Publicize Block editor plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.3
Development

Successfully merging this pull request may close these issues.
5 participants
@retrofox @matticbot @pablinos @DustyReagan @jeherve