WAF: Generate ip rules when running the update rules cron

[miguelxpn]

Fixes #27209

Changes proposed in this Pull Request:

• Regenerate the ip rules when running the cron that updates the waf rules

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Spin up a JN site with a Scan subscription.
• Turn on the WAF module
• SSH into the site and remove all the rules
• Run the cron via wp cron event run jetpack_waf_rules_update_cron
• Verify that both sets of rules were generated and that the site still works after the cron runs

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/waf-rule-cron to get started. More details: p9dueE-5Nn-p2

[anomiex]

What about the code path via line 334?

Or maybe to better future-proof this, we should just move the call to generate_ip_rules inside generate_rules instead of relying on every caller to do it.

[miguelxpn]

What about the code path via line 334?

Or maybe to better future-proof this, we should just move the call to generate_ip_rules inside generate_rules instead of relying on every caller to do it.

Good catch. Yeah I agree, that's part of what we'll do in a more elaborated patch. We also are going to add some better file handling around all file operations.

[samiff]

Reproduced fatal pre-patch, and verified that this patch resolves the immediate issue 👍

[coder-karen]

Cherry-picked to release branch in d7fbae8