Introduce Jetpack Newsletter in the recommendations flow

[mikestottuk]

Proposed changes:

This PR adds a new /recommendation/#newsletter path for the Recommendations

It also renames Subscriptions => Newsletter in the settings page

Jetpack product discussion

• N/A

Does this pull request change what data or activity we track or use?

My PR adds x and y.

Testing instructions

• If running Jetpack in development mode, clear the options at the bottom of the page
• Step through the "Recommendations" using Jetpack Free (i.e. not a paid plan)
• You should see the Newsletter recommendation
• Enable it, it should show up on the summary
• Navigate directly to the card wp-admin/admin.php?page=jetpack#/recommendations/newsletter it should show the status of the feature.

Copy is (and design image) still to be finalised - do not merge until later.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

• Next scheduled release: August 1, 2023.
• Scheduled code freeze: July 25, 2023.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the newsletter/recommendations branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack newsletter/recommendations
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jeherve]

Tests well for me. I only have one remark.

[jeherve]

We'll also need to update our e2e tests:

jetpack/projects/plugins/jetpack/tests/e2e/specs/post-connection/recommendations.test.js

Lines 62 to 72 in 21485d1

	await test.step( 'Enable Related Posts and continue to Creative Mail step', async () => {
	await recommendationsPage.enableRelatedPostsAndContinue();
	await recommendationsPage.reload();
	await recommendationsPage.waitForNetworkIdle();
	const isCreativeMailStep = await recommendationsPage.isInstallCreativeMailButtonVisible();
	expect( isCreativeMailStep, 'Creative Mail step should ne visible' ).toBeTruthy();
	expect(
	recommendationsPage.isUrlInSyncWithStepName( 'creative-mail' ),
	'URL should be in sync with the step name'
	).toBeTruthy();
	} );

[IanRamosC]

Other than what Jeremy already mentioned, I only noticed one minor thing: "Subscriptions" hasn't been renamed to "Newsletter" yet. This is where it needs update.

[mikestottuk]

Other than what Jeremy already mentioned, I only noticed one minor thing: "Subscriptions" hasn't been renamed to "Newsletter" yet. This is where it needs update.

Ah, I'd replaced it here /jetpack/projects/plugins/jetpack/modules/module-headings.php which must not be the right place (it changed on my test install)

[jeherve]

Ah, I'd replaced it here /jetpack/projects/plugins/jetpack/modules/module-headings.php which must not be the right place (it changed on my test install)

That file isn't checked in, you shouldn't edit it directly. If you wanted to rename the feature everywhere, and not just in the React dashboard, you would change the module name here:

jetpack/projects/plugins/jetpack/modules/subscriptions.php

Line 3 in 1be6652

* Module Name: Subscriptions

[mikestottuk]

Ah, I'd replaced it here /jetpack/projects/plugins/jetpack/modules/module-headings.php which must not be the right place (it changed on my test install)

That file isn't checked in, you shouldn't edit it directly. If you wanted to rename the feature everywhere, and not just in the React dashboard, you would change the module name here:

jetpack/projects/plugins/jetpack/modules/subscriptions.php

Line 3 in 1be6652

* Module Name: Subscriptions

I'll change it in the correct place. Hadn't noticed it not being checked in :)

[mikestottuk]

We'll also need to update our e2e tests:

jetpack/projects/plugins/jetpack/tests/e2e/specs/post-connection/recommendations.test.js

Lines 62 to 72 in 21485d1

	await test.step( 'Enable Related Posts and continue to Creative Mail step', async () => {
	await recommendationsPage.enableRelatedPostsAndContinue();
	await recommendationsPage.reload();
	await recommendationsPage.waitForNetworkIdle();
	const isCreativeMailStep = await recommendationsPage.isInstallCreativeMailButtonVisible();
	expect( isCreativeMailStep, 'Creative Mail step should ne visible' ).toBeTruthy();
	expect(
	recommendationsPage.isUrlInSyncWithStepName( 'creative-mail' ),
	'URL should be in sync with the step name'
	).toBeTruthy();
	} );

Ahhh - tests! I'll try and get my head around these today!

[jeherve]

Let's merge this and iterate on the links in a follow-up PR 🚢