Payments: add a default scenario for our upgrade nudges

[jeherve]

Fixes #31982

Proposed changes:

We currently have the following logic for the support doc link in the Stripe connection nudge banner:

For the Payments buttons:

• on WordPress.com Simple sites: https://wordpress.com/support/wordpress-editor/blocks/payments/
• On self-hosted sites: https://jetpack.com/support/jetpack-blocks/payments-block/#related-fees

For the Donations block:

• on simple: https://wordpress.com/support/wordpress-editor/blocks/donations/
• on self-hosted: https://jetpack.com/support/jetpack-blocks/donations-block/

For the Premium Content block as well as any other block (this ends up being the default):

• on simple: https://wordpress.com/support/wordpress-editor/blocks/premium-content-block/ -> this currently redirects to https://wordpress.com/support/wordpress-editor/blocks/paid-content-block/
• on self-hosted: https://jetpack.com/support/jetpack-blocks/payments-block/#related-fees

That last, default behavior seems to be the problem here, because we have at least one other block name, recurring-payments, that is not handled here. This PR fixes that by setting up a default.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• N/A

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

This can be tested on WordPress.com Simple and on self-hosted, on a site where you have not tested those blocks before and have not connected your site to a Stripe account. In that scenario:

1. Go to Posts > Add New
2. Add a Payments block, and then pick each variation, one at a time, and check the support link in the Stripe connection banner.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/payments-block-fees-link branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/payments-block-fees-link
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

• Next scheduled release: August 1, 2023.
• Scheduled code freeze: July 24, 2023.

[samiff]

Should the switch case statements be using break here? If I'm using a donations block for example, it currently falls through to the default for readMoreUrl.

[jeherve]

Should the switch case statements be using break here? If I'm using a donations block for example, it currently falls through to the default for readMoreUrl.

Well yes that would help, wouldn't it? :) Done in 9ee7b91

I'm going to dismiss this review because the fix was implemented. Thanks for taking a look, Sami!