Skip to content

Conversation

edanzer
Copy link
Contributor

@edanzer edanzer commented Oct 3, 2025

Proposed changes:

Adds an integration store to store integrations data retrieved via endpoint. The integrations data is used on many pages, and having the store will allow us to load data from the store, avoid repeated calls to the endpoint, improve load time, and avoid loading spinners and flickers in most cases (especially when combined with pre-loading endpoints).

Specific changes;

  • Add integration store
  • Update the dashboard integrations panel to use the new store, as an example

Assuming we adopt this, I'll updated other parts of the interface to use the store in future PRs.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Follows suggestion from @enejb to add the store and mimic the dashboard store here.

See slack: p1759441431330189-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

From a user perspective, nothing changes here. We're just updating how we get and store the forms data behind the scenes. To test, just go to the Jetpack > Forms > Integrations screen and confirm integrations load quickly and as before. Try installing and activating plugins to confirm that changes in integration status are handled gracefully and don't trigger any unwanted loading states.

@edanzer edanzer requested a review from a team October 3, 2025 19:10
@edanzer edanzer self-assigned this Oct 3, 2025
@edanzer edanzer added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Pri] Normal [Package] Forms labels Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-integrations-store branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/forms-integrations-store

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 7, 2025
    • Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Oct 3, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/integrations/index.tsx 0/29 (0.00%) 0.00% 3 ❤️‍🩹

7 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/store/integrations/action-types.ts 0/4 (0.00%) 💔
projects/packages/forms/src/store/integrations/actions.ts 0/5 (0.00%) 💔
projects/packages/forms/src/store/integrations/index.ts 0/3 (0.00%) 💔
projects/packages/forms/src/store/integrations/reducer.ts 0/7 (0.00%) 💔
projects/packages/forms/src/store/integrations/resolvers.ts 0/12 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@edanzer edanzer force-pushed the add/forms-integrations-store branch from 17aa9bc to a6b36e0 Compare October 3, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant