Skip to content

Settings UI: remove external icon in links #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2017
Merged

Settings UI: remove external icon in links #6252

merged 2 commits into from
Feb 2, 2017

Conversation

eliorivero
Copy link
Contributor

Fixes #6202

Changes proposed in this Pull Request:

  • remove icon in external links for subscriptions, backups and seo.

Testing instructions:

  • make sure those links don't have icons

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. labels Feb 1, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 1, 2017
@eliorivero eliorivero self-assigned this Feb 1, 2017
@MichaelArestad
Copy link
Contributor

Made a super minor change (removed a period). Looks good. Thanks!

@MichaelArestad MichaelArestad added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 2, 2017
@eliorivero eliorivero merged commit a40d46d into feature/settings-overhaul Feb 2, 2017
@eliorivero eliorivero deleted the update/remove-icon-disconnect-link branch February 2, 2017 14:45
@eliorivero
Copy link
Contributor Author

Thanks!

@eliorivero eliorivero mentioned this pull request Feb 2, 2017
Closed
3 tasks
@MichaelArestad MichaelArestad mentioned this pull request Feb 20, 2017
Merged
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu
Projects
None yet
Milestone
Settings UI
Development

Successfully merging this pull request may close these issues.
3 participants
@eliorivero @MichaelArestad @kraftbj