Skip to content

Removes trailing periods from settings labels #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2017
Merged

Removes trailing periods from settings labels #6259

merged 2 commits into from
Feb 2, 2017

Conversation

MichaelArestad
Copy link
Contributor

Fixes #6220

Changes proposed in this Pull Request:

  • Removes all trailing periods from settings labels

Testing instructions:

  • Go to all settings sections and look for any trailing periods on toggle/checkbox labels.

Example before:

image

Example after:

image

@MichaelArestad MichaelArestad added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 1, 2017
@MichaelArestad MichaelArestad self-assigned this Feb 1, 2017
MichaelArestad
MichaelArestad commented Feb 1, 2017
View reviewed changes
modules/module-headings.php Outdated
'custom-content-types' => array(
'name' => _x( 'Custom Content Types', 'Module Name', 'jetpack' ),
'description' => _x( 'Organize and display different types of content on your site.', 'Module Description', 'jetpack' ),
'description' => _x( 'Display different types of content on your site with custom content types.', 'Module Description', 'jetpack' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this changed. Ideas?

@MichaelArestad
Copy link
Contributor Author

Looks like a few lines in module-headings.php changed. No idea why since it's generated. Ideas?

@eliorivero
Copy link
Contributor

If some lines in module-headings.php changed then the description in the related module file header changed and that must be probably me, since I updated some of the descriptions to match the texts in the mockups in p6TEKc-HQ-jpopdesignp2.

@jeherve jeherve added this to the Settings UI milestone Feb 2, 2017
@eliorivero
Copy link
Contributor

Needs rebasing and restoring the module-headings.php file.

@eliorivero eliorivero force-pushed the remove/trailing-dots branch from 1c3c338 to d9555b0 Compare February 2, 2017 16:25
@eliorivero
Copy link
Contributor

Rebased and restored.

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 2, 2017
@MichaelArestad
Copy link
Contributor Author

@eliorivero You're the best. Thank you.

@MichaelArestad MichaelArestad merged commit 8c125fb into feature/settings-overhaul Feb 2, 2017
@MichaelArestad MichaelArestad deleted the remove/trailing-dots branch February 2, 2017 16:29
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaelArestad MichaelArestad

Labels
Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Settings UI
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelArestad @eliorivero @kraftbj @jeherve @matticbot