Skip to content

Conversation

dereksmart
Copy link
Contributor

@dereksmart dereksmart commented Feb 10, 2017

Any errors reported by eslint (yarn lint) will now fail Travis in this new test suite.

To test:

  • Verify that tests pass
  • You should still see the warnings in the test suite in the travis UI

@dereksmart dereksmart force-pushed the test/should-fail-travis branch from f4150d8 to 56ab5a3 Compare February 10, 2017 17:15
@dereksmart dereksmart changed the title test travis failure Travis: New test to check for eslint rules Feb 10, 2017
@dereksmart dereksmart force-pushed the test/should-fail-travis branch from 56ab5a3 to eced480 Compare February 10, 2017 17:18
@eliorivero
Copy link
Contributor

This test continues failing

1) WP_Test_Jetpack_Sync_Sender::test_limits_execution_time_of_do_sync

but it's not the scope of this PR. The changes introduced work fine 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 10, 2017
@oskosk
Copy link
Contributor

oskosk commented Feb 10, 2017

LGTM. Tested running yarn lint and npm run lint after introducing a lodash named import and checking for build errors in PR #6368 created only for my tests of this PR . Errors were shown. when lint run locally and and Travis failed on #6368 :shipit:

@dereksmart dereksmart merged commit 8685ab2 into feature/settings-overhaul Feb 10, 2017
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2017
@dereksmart dereksmart deleted the test/should-fail-travis branch February 10, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants