Skip to content

Settings: fixes remaining font size and spacing issues #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2017
Merged

Settings: fixes remaining font size and spacing issues #6377

merged 1 commit into from
Feb 13, 2017

Conversation

MichaelArestad
Copy link
Contributor

Changes proposed in this Pull Request:

  • makes p font size in settings 15px to match Calypso (for now)
  • resolves some remaining spacing issues

Testing instructions:

  • go to settings and look at
    • Traffic > SEO
    • Traffic > Site Stats (added a br)
    • Traffic > Site Verification
    • Security > Backups & Security (also removed grey text)

Before

image
image
image

After

image
image
image

@MichaelArestad MichaelArestad added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 11, 2017
@MichaelArestad MichaelArestad self-assigned this Feb 11, 2017
@MichaelArestad
Copy link
Contributor Author

Resolves some of these: #6210

@MichaelArestad MichaelArestad mentioned this pull request Feb 11, 2017
Merged
@dereksmart dereksmart added this to the Settings UI milestone Feb 13, 2017
@eliorivero
Copy link
Contributor

Looks better and this completes #6210

@eliorivero eliorivero merged commit 7dc25c1 into feature/settings-overhaul Feb 13, 2017
@eliorivero eliorivero deleted the fix/remaining-settings-spacing branch February 13, 2017 19:11
@eliorivero eliorivero removed the [Status] Needs Review This PR is ready for review. label Feb 13, 2017
@eliorivero eliorivero mentioned this pull request Feb 13, 2017
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaulebens beaulebens Awaiting requested review from beaulebens

Assignees

@MichaelArestad MichaelArestad

Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Settings UI
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelArestad @eliorivero @dereksmart