Skip to content

Fixes settings info popover collision with labels #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2017
Merged

Fixes settings info popover collision with labels #6392

merged 1 commit into from
Feb 13, 2017

Conversation

eliorivero
Copy link
Contributor

Fixes #6195

Follow up of #6359

Changes proposed in this Pull Request:

  • Adds extra padding that prevents infopopover icon from colliding with text/labels/elements

NOTE: It does not work on these, but there is an issue to fix/move those anyway:
image

Testing instructions:

  • Go to each panel in settings and resize the window a bunch looking for text collisions

Before

image

After

image

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 13, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 13, 2017
@eliorivero eliorivero mentioned this pull request Feb 13, 2017
Closed
@eliorivero
Copy link
Contributor Author

Effectively fixes the collision 👍

@eliorivero eliorivero merged commit 6f0df0e into feature/settings-overhaul Feb 13, 2017
@eliorivero eliorivero removed the [Status] Needs Review This PR is ready for review. label Feb 13, 2017
@eliorivero eliorivero deleted the fix/popover-collision-2 branch February 13, 2017 18:25
@eliorivero eliorivero mentioned this pull request Feb 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaulebens beaulebens Awaiting requested review from beaulebens

Assignees

@MichaelArestad MichaelArestad

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Settings UI
Development

Successfully merging this pull request may close these issues.
2 participants
@eliorivero @MichaelArestad