Skip to content

Conversation

dereksmart
Copy link
Contributor

Fixes #6200

This seems like the most straightforward way to make the settings labels click toggle.

It works, but I feel like there might be something else that we're missing to make this possible. I didn't see any special instructions in dops-components readme or the form-toggle component itself.

To test:

  • Click the settings labels with toggles to see the settings toggle.
  • Make sure correct setting gets saved.

@dereksmart dereksmart added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 14, 2017
@dereksmart dereksmart added this to the Settings UI milestone Feb 14, 2017
@eliorivero
Copy link
Contributor

This works fine for ModuleToggle.
Now, there are more than a few places where FormToggle was used instead of ModuleToggle for options that need to take into account more than the module state, for example the toggles for custom post types, the child toggles for infinite scroll and mobile themes, and others.
Maybe the best approach would be to bring in the updates to FormToggle and in that way we can update both ModuleToggle and FormToggle
https://github.com/Automattic/wp-calypso/pull/11158/files

@dereksmart
Copy link
Contributor Author

replaced. see #6425

@dereksmart dereksmart closed this Feb 15, 2017
@dereksmart dereksmart deleted the fix/click-label-toggle-setting branch February 15, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants