Refactors intermediate searchable components to handle props more efficiently. #6429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinigor
added
General
[Status] In Progress
[Type] Enhancement
zinigor
changed the title
|
I'm worried that we're spending too much time on search when there are things like banners The priority should be to finish the banners PR and then we can revisit search. The banners integration is essential also for other areas like #6207, #6225 and similar setting cards. Search is nice for now, so other than make the middle components in Writing consistent with those in the other tabs, we should leave it as is for now and focus on blocker tasks and revisit it later. |
This will probably get reverted because there is no good way to determine from the SettingsCard if there are any children rendered inside of it.
|
I agree with @eliorivero -- let's get the critical path items out the door before we start refactoring :) |
|
Closing this as abandoned for now. We can reopen in the future. |
samhotchkiss
added
[Status] Abandoned
[Status] In Progress
and removed
[Status] In Progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6417. This is still a WIP.
Changes proposed in this Pull Request: