-
Notifications
You must be signed in to change notification settings - Fork 834
Preview different Plan UI's with a radio toggle #6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Internal dependencies | ||
*/ | ||
import { isDevVersion as _isDevVersion } from 'state/initial-state'; | ||
import { switchMichaelsPlan } from 'state/dev-version'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use people's names in our codebase?
} | ||
}; | ||
|
||
export const switchMichaelsPlan = ( slug ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "previewAnotherPlan" or something like that?
Noice! Should we just be showing this to all users running a dev version? Our goal over the next few months is to get many more beta testers, and this seems like it might be a bit unnecessary/confusing. What about a little footer link to turn this thing on? Or... |
b65fe68
to
3593238
Compare
Ha, the eternal quest of MOAR testers. I was thinking of putting it behind a filter. |
…rd. Added footer link to allow toggling of plans.
Love it! |
This PR adds a new component
DevCard
to the mix, which is rendered in the footer only if Jetpack is running in a development version.Right now it only allows you to toggle between different Jetpack plans so that you're able to view the UI differences.
Toggling between these is not actually changing your plan, it is only updating the state for viewing/testing purposes of the UI -- aka: Your plan is expected to revert back to your actual plan when the /site endpoint is queried next, so that is NOT a bug.
There is no doubt that this can be improved/expanded a great deal in the future (and it will), but for now this PR is meant to be a quick win for designers/growth when they are testing differences between plans.
To Test:
/wp-admin/admin.php?page=jetpack#/plans
tab.4.8
, make sure the component does not render.