Add build step to linting. #6495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it happens that the Travis build passes when the build actually fails. It happens because we weren't building the actual bundle before, but this commit introduces a build command before actual linting. That will make sure that Travis builds fail if the project doesn't build successfully or that jshint fails.
zinigor
added
General
[Status] Needs Review
dereksmart
added
[Status] Ready to Merge
samhotchkiss
removed
the
[Status] Ready to Merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it happens that the Travis build passes when the build actually fails. It happens because we weren't building the actual bundle before, but this commit introduces a build command before actual linting. That will make sure that Travis builds fail if the project doesn't build successfully or that jshint fails.