Invalid atomic update value for $set. Expected an object, received object

[tosbaha]

If I try to update my document via

Parcel.findOneAndUpdate({_id:parcel.trackingID},{$set:parcel},{new: true},function(err,result) {
    //
})

I get Invalid atomic update value for $set. Expected an object, received object error. However if I do,

Parcel.findOneAndUpdate({_id:parcel.trackingID},parcel,{new: true},function(err,result) {
  //
})

It is working without any error. parcel is an object which has the same properties with a schema plus some extra properties.

[vkarpov15]

Hmm can you show me how you're constructing the parcel object? Hard to tell without knowing what that object actually is.

[tosbaha]

Hi,
Here is my failing test with relevant code

Models

//user.js

var mongoose = require('mongoose');

var UserSchema = mongoose.Schema({
    email: {type: String, index: {unique: true, sparse: true}},
    password: String,
    createdOn: {type: Date, default:Date.now }
});

UserSchema.virtual('parcels',{
    ref: 'Parcel',
    localField:'_id',
    foreignField:'owner'
});

var User = mongoose.model("User", UserSchema);
module.exports = User;

//parcel.js
var mongoose = require('mongoose');
var ParcelSchema = mongoose.Schema({
    owner : { type:mongoose.Schema.Types.ObjectId, ref: 'User' },
    trackingNumber: String,
    slug:String,
    lang:String,
    extra:String,
    details:[{
        _id:false,
        message: String,
        location: String,
        date: Date,
        status: Number
    }]
});

ParcelSchema.pre('save', function (next) {
    this.updateDate = new Date();
    next();
});

ParcelSchema.methods.toJSON = function() {
    var obj = this.toObject();
    delete obj.__v;
    return obj;
};

var Parcel = mongoose.model("Parcel", ParcelSchema);
module.exports = Parcel;

//trackings.js

(function() {
    'use strict';

    var _util = require('util');
    function Trackings() {
    }

    _util.inherits(Trackings, Array);
    module.exports = Trackings;

})();



//kargo.js

(function () {
    'use strict';
    function Kargo(kargo) {
        kargo = kargo || {};
        this.trackingNumber = kargo.trackingNumber || null;
        this.details = kargo.details || [];
        this.extra = kargo.extra || null;
        this.lang = kargo.lang || null;
        this.dna = kargo.dna || null;
        this.trackingID = kargo._id || kargo.trackingID || null;
    }

    module.exports = Kargo;
})();

Test Code

var should = require('should');
var mongoose = require('mongoose');

var Parcel = require('../parcel');
var User = require('../user');
var Trackings = require('../trackings');
var Kargo = require('../kargo');


mongoose.Promise = global.Promise; //mongoose workaround

describe('Mongoose Test',function () {
    var anonUserId;
    var trackingId;
    var trackings = new Trackings();

    before (function (done) {
        mongoose.connect('mongodb://localhost', function(err) {
            Parcel.remove().exec();
            User.remove().exec();
            done();
        });
    });

    it('should create user and parcel',function(done) {
        var user = new User();
        user.email = 'anonuser@hotmail.com';
        user.password = '$2a$08$Dxkzj2Nsjt09Tt5/U2yg/uUNRi93Pzwgpc5nsie7nXAoiJZxpl20C';
        user.save(function(err) {
            if (err) {
                done(err);
            } else {
                anonUserId = user._id;
                console.log(anonUserId);
                done();
            }
        });

    });

    it('should add parcel to user',function(done) {
        var parcel = new Parcel();
        parcel.owner = anonUserId;
        parcel.slug = 'single';
        parcel.trackingNumber = '39';

        parcel.save(function(err) {
            if (err) {
                done(err);
            } else {
                trackingId = parcel._id;
                trackings.push(new Kargo({
                    trackingNumber: '39',
                    trackingID: trackingId,
                    dna: 'FAKEDNA', //fake DNA
                    extra:'30.05.2016',
                    lang: 'en'
                }));
                done();
            }
        });
    });

    it('should list parcels of Anon User', function(done) {
        User.findOne({_id:anonUserId}).populate('parcels').exec(function(err,user) {
            user.should.not.be.null();
            done();
        });
    });

    it('should update parcel with object',function (done) {
       var parcel = new Kargo( {
           trackingNumber: '39',
           trackingID: trackingId,
           dna: 'FAKEDNA', //fake DNA
           extra:'30.05.2016',
           lang: 'fr' //change language to FR
       });

        Parcel.findOneAndUpdate({_id:trackingId},parcel,{new: true},function(err,result) {
            result.lang.should.be.eql('fr');
            done(err);

        });
    });


    it('should update parcel with $set',function (done) {
        var parcel = new Kargo( {
            trackingNumber: '39',
            trackingID: trackingId,
            dna: 'FAKEDNA', //fake DNA
            extra:'30.05.2016',
            lang: 'es' //change language to ES
        });

        Parcel.findOneAndUpdate({_id:trackingId},{$set:parcel},{new: true},function(err,result) {
            result.lang.should.be.eql('es');
            done(err);
        });
    });
});

Testing fails that can't read lang of null. If I comment out assert code err says that

Error: Invalid atomic update value for $set. Expected an object, received object