Skip to content

Conversation

@ItsBradyDavis
Copy link
Contributor

Summary
Adds pluralization for woman, cactus, focus, fungus, nucleus, and fixes the pluralization of virus from viri to viruses

Examples
woman -> women
virus -> viruses
cactus -> cacti
focus -> foci
fungus -> fungi
nucleus -> nuclei

Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only concern would be that this is a breaking change that we'd have to ship in v9.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm going to have to merge this into 9.0 branch because this is backwards breaking.

@vkarpov15 vkarpov15 added this to the 9.0 milestone Jan 26, 2024
@vkarpov15 vkarpov15 changed the base branch from master to 9.0 January 26, 2024 16:48
@vkarpov15 vkarpov15 merged commit 0e073c7 into Automattic:9.0 Jan 26, 2024
@ItsBradyDavis ItsBradyDavis deleted the pluralizationAdditions branch January 26, 2024 17:29
@markstos
Copy link
Contributor

I disagree with most of these, because they are acceptable alternatives listed in official dictionaries as such. Given that, in the spirit of backwards compatible, I recommend keeping "cactuses", "focuses", "funguses" and "nucleuses"

Ref:

I may be a little salty because I'm many, many hours into a Mongoose 5➡️6 upgrade that's so far about 60 commits and 2,000 lines deep. It's a big, old code base that has triggered a number of the documented breaking changes as well as least a couple undocumented breaking changes.

I think Mongoose has made a lot of good calls with the breaking changes it has made, but unnecessary changes can become paper cuts, or worse, new bugs in production.

So while, yes, the recommended plurals are the most correct, the ones in place now are recognized as valid English and may save some cactus farmers some upgrade headache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants