fix(types): allow partial statics in Schema.static() #15786
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15780
Problem
When using
Schema.static({...})with TypeScript generics, TypeScript requiredthat all properties defined in
TStaticMethodsbe present in the object passedto
schema.static(). This prevented users from adding statics one at a time.Solution
Make the mapped type keys optional:
{ [F in keyof TStaticMethods]?: TStaticMethods[F] }This aligns
Schema.static()with the behavior ofSchema.method()and allowsincremental addition of static methods.
Notes