Fix Electron 5 and NodeJS 12 compatibility #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron 5 is still in beta and will be shipped with Node 12. There are some breaking changes to native modules: https://electronjs.org/blog/nodejs-native-addons-and-electron-5
With latest version the command
node-gyp rebuild --target=5.0.0-beta.5 --runtime=electronfails. This PR fixes build, and it works fine with my Electron application.Unfortunately, some new deprecated warnings have appeared. I'm not so experienced in writing native addons and I'd appreciate help with that. Or, if it is necessary, I could give it a try, but need more time with that.