Fix ES6 syntax usage for IE #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
force-pushed
the
browser-ie11-syntax
branch
from
bd09049 to
995d2bd
Compare
mhuggins
changed the title
mhuggins
force-pushed
the
browser-ie11-syntax
branch
3 times, most recently
from
9dae8e6 to
34d034c
Compare
zbjornson
approved these changes
Apr 24, 2019
thisconnect
reviewed
Apr 24, 2019
mhuggins
force-pushed
the
browser-ie11-syntax
branch
from
34d034c to
57d17fc
Compare
Contributor
Author
|
@zbjornson I fixed the quote issue that was called out and rebased against master. |
thisconnect
approved these changes
Apr 28, 2019
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 throws an error due to the object literal, arrow function, and string interpolation syntax used by
browser.js. This fixes those usages so that the canvas package can run properly.I tested these changes locally by directly applying these changes within my project's node_modules folder, and it fixed all IE errors, allowing the page to load.