Skip to content

adds crossOrigin attribute to loadImage #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2019
Merged

adds crossOrigin attribute to loadImage #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9424bf5
adds crossOrigin attribute to loadImage
thisconnect Apr 5, 2019
3e30bd8
Standard Style
thisconnect Apr 7, 2019
4dc261f
support any properties on an HTMLImageElement
thisconnect Apr 20, 2019
55b24fb
loadImage accepts any options now
thisconnect Apr 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ exports.createImageData = function (array, width, height) {
}
}

exports.loadImage = function (src) {
exports.loadImage = function (src, options) {
return new Promise((resolve, reject) => {
const image = document.createElement('img')
const image = Object.assign(document.createElement('img'), options)

function cleanup () {
image.onload = null
Expand Down
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export function createImageData(width: number, height: number): ImageData
* @param src URL, `data: ` URI or (Node.js only) a local file path or Buffer
* instance.
*/
export function loadImage(src: string|Buffer): Promise<Image>
export function loadImage(src: string|Buffer, options?: any): Promise<Image>

/**
* Registers a font that is not installed as a system font. This must be used
Expand Down