Skip to content

Conversation

@LinusU
Copy link
Collaborator

@LinusU LinusU commented May 26, 2016

Fixes #773

@LinusU
Copy link
Collaborator Author

LinusU commented May 26, 2016

ping @rlidwka, would you mind reviewing/testing this for me? :)

I have verified that the image does indeed get smaller, and it's no longer a multiple of 4096. It can also open the image in the Preview app in OS X so it seems valid.

@LinusU
Copy link
Collaborator Author

LinusU commented May 26, 2016

@TooTallNate @kangax @rvagg @kkoopa @zbjornson

Any thoughts on how to handle this, we are leaking users memory, potentially in web apps which could be exploited.

I think that we should npm deprecate all the current versions with a message on what's happening and urging all users to update to a version that we'll publish when we merge this.

@zbjornson
Copy link
Collaborator

That sounds reasonable and responsible. By "all current versions" do you mean all 86 published versions?

Nice job getting a fix submitted quickly. 👍

@LinusU LinusU merged commit 604ba09 into Automattic:master May 29, 2016
@LinusU LinusU deleted the fix-data-leak branch May 29, 2016 15:45
@LinusU
Copy link
Collaborator Author

LinusU commented May 29, 2016

Published as 1.3.16

Would still appreciate input on how to move forward with the deprecation...

@kkoopa
Copy link
Contributor

kkoopa commented May 29, 2016

I guess whether to deprecate or not depends on how much JPEG streaming is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants