Prepare release archive using composer #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatho
reviewed
Nov 18, 2021
Contributor
renatho
left a comment
renatho
left a comment
There was a problem hiding this comment.
Awesome! This will be super helpful! 😃
I tested installing in a clean site and it worked well!
I just added some small suggestions.
Also, probably you noticed it only works with node v10 because of the cgb-scripts right? Maybe we could take this PR opportunity to also add it to the package.json. WDYT?
package.json
Outdated
| "preinstall": "npx npm-force-resolutions" | ||
| "preinstall": "npx npm-force-resolutions", | ||
| "archive": "composer archive --file=$npm_package_name --format=zip", | ||
| "release": "npm run build && npm run archive" |
Contributor
There was a problem hiding this comment.
I wonder if we could add it as part of the build script too similar to Sensei, so we keep consistency in the scripts between the projects while releasing. WDYT?
Contributor
Author
There was a problem hiding this comment.
Yes, that's a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Changes proposed in this Pull Request
composer.jsonconfig.archiveandreleasescripts fornpm..zipand/vendorto.gitignore.Testing instructions
composer installandnpm installnpm run releasesyntaxhighlighter.zip