Fix Pixelfed interactions (Likes) #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures object URLs in Like activities are normalized by removing trailing slashes before processing, improving compatibility with platforms like Pixelfed. Adds tests to verify correct handling and storage of Like activities with trailing slashes in object URLs.
Added a check in is_activity_public to return true when the recipients list is empty, ensuring activities without specified recipients are considered public.
Updated logic to treat activities without recipients as public, delivering them to all local actors. Adjusted related tests to reflect this behavior and removed unnecessary untrailingslashit calls for URL normalization.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of ActivityPub activities from Pixelfed and other platforms by treating activities with no recipients as public, which aligns with the ActivityPub specification.
- Updated
is_activity_public()function to returntruewhen an activity has no recipients - Added test coverage for Like activities with trailing slashes in object URLs (common with Pixelfed)
- Updated existing tests to reflect the new behavior where activities without recipients are treated as public
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| includes/functions.php | Added check in is_activity_public() to treat activities with no recipients as public |
| tests/phpunit/tests/includes/rest/class-test-inbox-controller.php | Updated test to expect all local actors to receive activities with no recipients (treated as public) |
| tests/phpunit/tests/includes/handler/class-test-like.php | Added test for Like activities with trailing slashes in object URLs |
| tests/phpunit/tests/includes/collection/class-test-inbox.php | Updated visibility test and added test for Like activities with trailing slashes |
| tests/phpunit/tests/includes/class-test-functions.php | Updated test expectation for activities with no standard recipient fields to be treated as public |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
changed the title
obenland
reviewed
Nov 12, 2025
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Updated get_activity_visibility to return public visibility for activities without recipients. Adjusted related unit test to reflect this behavior change, ensuring empty activities are now considered public.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
obenland
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes handling of ActivityPub activities from Pixelfed and other platforms by treating activities with no recipients as public, which aligns with the ActivityPub specification.
Fixes https://wordpress.org/support/topic/boosts-reposts-not-working-in-pixelfed/
Proposed changes:
is_activity_public()function to returntruewhen an activity has no recipientsOther information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Fixed compatibility with Pixelfed and similar platforms by treating activities without recipients as public, ensuring boosts and reposts work correctly.