Fix Social Web webpack chunk output paths #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
[Focus] Editor
Member
|
oops! |
obenland
force-pushed
the
update/social-web-build
branch
from
e9a7abe to
3e18f5f
Compare
pfefferle
reviewed
Nov 18, 2025
pfefferle
reviewed
Nov 18, 2025
| "integrity": "sha512-eohl3hKTiVyD1ilYdw9T0OiB4hnjef89e3dMYKz+mVKDzj+5IteTseASUsOB+EU9Tf6VNTCjDePcP6wkDGmLKQ==", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "peer": true, |
Member
There was a problem hiding this comment.
What are these artifacts? I also had them several times!?
Member
Author
There was a problem hiding this comment.
It indicates that a package is installed to satisfy a peer dependency requirement from another package rather than being a direct or transitive regular dependency.
Updates webpackChunkName comments in lazy imports to include the social-web/ prefix, ensuring feed-stage and feed-inspector chunks output to build/social-web/ instead of the build root directory. This aligns with the existing vendors chunk naming pattern.
obenland
force-pushed
the
update/social-web-build
branch
from
1c7ad11 to
0f3b6ec
Compare
pfefferle
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the webpack chunk output directory issue where
feed-stage.jsandfeed-inspector.jswere being output to the rootbuild/directory instead ofbuild/social-web/.Changes
webpackChunkNamecomments in lazy imports to include thesocial-web/prefixfeed-stage→social-web/feed-stagefeed-inspector→social-web/feed-inspectorThis aligns with the existing
social-web/vendorschunk naming pattern and ensures all social-web chunks are properly organized in the same directory.Testing
build/social-web/:feed-inspector.jsfeed-stage.jsstyle-feed-stage-rtl.cssstyle-feed-stage.css