Improve Create handler: Maintain consistent return values #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to commit 8798394 which replaced action hooks with direct method calls. After calling Update::handle_update(), explicitly fetch and return fresh objects to maintain consistent return types and values across all code paths. Additional improvements: - Rename $check_dupe to $existing_comment and $existing_post for clarity - Use instanceof check instead of !is_wp_error() for better type safety - Fix comment and docblock accuracy in create_post()
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Create handler to maintain consistent return values and prevent duplicate notifications when processing duplicate ActivityPub Create activities. The changes ensure that when a duplicate comment or post is detected, Update::handle_update() is called to process it as an update, and the method returns false to prevent the activitypub_handled_create action from firing.
Key Changes:
- Return
falseafter callingUpdate::handle_update()for existing comments/posts to prevent duplicate notifications - Improve variable naming from
$check_dupeto$existing_commentand$existing_postfor better code clarity - Use
instanceof \WP_Postinstead of! \is_wp_error()for more accurate type checking increate_post()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
previously approved these changes
Nov 20, 2025
pfefferle
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to
8798394(#2500)Proposed changes:
falseafter callingUpdate::handle_update()for existing comments/posts to prevent duplicate notifications via theactivitypub_handled_createaction$check_dupeto$existing_commentand$existing_postfor improved code readabilityinstanceof \WP_Postinstead of! \is_wp_error()for more accurate type checkingfalseis returned when duplicates are foundcreate_post()Other information:
Testing instructions:
Update::handle_update()is calledactivitypub_handled_createaction doesn't fire for duplicates)Changelog entry
Changelog Entry Details
Significance
Type
Message
Maintain consistent return values in Create handler.