Skip to content

Commit 25f88a4

Browse files
committed
Rename last_updated_at to last_fetched_at in list metadata
Improves naming consistency with `last_first_page_fetched_at`. The field tracks when any page was last fetched, so `last_fetched_at` is clearer than the ambiguous `last_updated_at`. Changes: - Rename column in SQL migration - Update `DbListMetadata` struct field - Update `ListMetadataColumn` enum variant - Update repository SQL and tests
1 parent 2918b33 commit 25f88a4

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

wp_mobile_cache/migrations/0007-create-list-metadata-tables.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ CREATE TABLE `list_metadata` (
88
`current_page` INTEGER NOT NULL DEFAULT 0,
99
`per_page` INTEGER NOT NULL DEFAULT 20,
1010
`last_first_page_fetched_at` TEXT,
11-
`last_updated_at` TEXT,
11+
`last_fetched_at` TEXT,
1212
`version` INTEGER NOT NULL DEFAULT 0,
1313

1414
FOREIGN KEY (db_site_id) REFERENCES db_sites(id) ON DELETE CASCADE

wp_mobile_cache/src/db_types/db_list_metadata.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pub enum ListMetadataColumn {
1818
CurrentPage = 5,
1919
PerPage = 6,
2020
LastFirstPageFetchedAt = 7,
21-
LastUpdatedAt = 8,
21+
LastFetchedAt = 8,
2222
Version = 9,
2323
}
2424

@@ -42,7 +42,7 @@ impl DbListMetadata {
4242
current_page: row.get_column(Col::CurrentPage)?,
4343
per_page: row.get_column(Col::PerPage)?,
4444
last_first_page_fetched_at: row.get_column(Col::LastFirstPageFetchedAt)?,
45-
last_updated_at: row.get_column(Col::LastUpdatedAt)?,
45+
last_fetched_at: row.get_column(Col::LastFetchedAt)?,
4646
version: row.get_column(Col::Version)?,
4747
})
4848
}

wp_mobile_cache/src/list_metadata.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ pub struct DbListMetadata {
2121
pub per_page: i64,
2222
/// ISO 8601 timestamp of when page 1 was last fetched
2323
pub last_first_page_fetched_at: Option<String>,
24-
/// ISO 8601 timestamp of last update
25-
pub last_updated_at: Option<String>,
24+
/// ISO 8601 timestamp of when any page was last fetched
25+
pub last_fetched_at: Option<String>,
2626
/// Version number, incremented on page 1 refresh for concurrency control
2727
pub version: i64,
2828
}

wp_mobile_cache/src/repository/list_metadata.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ impl ListMetadataRepository {
277277
self.get_or_create(executor, site, key)?;
278278

279279
let sql = format!(
280-
"UPDATE {} SET total_pages = ?, total_items = ?, current_page = ?, per_page = ?, last_updated_at = strftime('%Y-%m-%dT%H:%M:%fZ', 'now') WHERE db_site_id = ? AND key = ?",
280+
"UPDATE {} SET total_pages = ?, total_items = ?, current_page = ?, per_page = ?, last_fetched_at = strftime('%Y-%m-%dT%H:%M:%fZ', 'now') WHERE db_site_id = ? AND key = ?",
281281
Self::header_table().table_name()
282282
);
283283

@@ -747,7 +747,7 @@ mod tests {
747747
fn test_list_metadata_column_enum_matches_schema(test_ctx: TestContext) {
748748
// Verify column order by selecting specific columns and checking positions
749749
let sql = format!(
750-
"SELECT rowid, db_site_id, key, total_pages, total_items, current_page, per_page, last_first_page_fetched_at, last_updated_at, version FROM {}",
750+
"SELECT rowid, db_site_id, key, total_pages, total_items, current_page, per_page, last_first_page_fetched_at, last_fetched_at, version FROM {}",
751751
ListMetadataRepository::header_table().table_name()
752752
);
753753
let stmt = test_ctx.conn.prepare(&sql);
@@ -954,7 +954,7 @@ mod tests {
954954
assert_eq!(header.total_items, Some(100));
955955
assert_eq!(header.current_page, 1);
956956
assert_eq!(header.per_page, 20);
957-
assert!(header.last_updated_at.is_some());
957+
assert!(header.last_fetched_at.is_some());
958958
}
959959

960960
#[rstest]

0 commit comments

Comments
 (0)