Fix flaky network tests #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky test case for WordPress 5.7 – it can't connect to a MySQL 8+ instance (most of the time, weirdly – it sometimes works in CI?!). The error messaging wasn't clear though – it really looked like a race condition between MySQL being ready and the script running (because the error just said "unable to connect to database").
This PR:
mysql
container name for backward compatibility)setup-test-site.sh
. This allows the docker container to start its work right away, cutting about 20 seconds off the setup time while improving reliability by opening a connection from thewordpress
container to themysql
one before attempting any further setup.wp db check
usesmysqlcheck
under the hood, so we get detailed error information if the connection fails.wp-cli
cache directory to silence a warningTo test: