Fix exception handling in Kotlin request executor #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive exception handling to prevent UnexpectedUniFFICallbackError crashes when network exceptions occur. The executor now properly catches and maps all exceptions to appropriate Rust error types. Without proper exception handling, uncaught exceptions from OkHttp would crash the UniFFI callback layer instead of being returned as proper errors to Rust. This was causing API discovery and other network operations to fail with UnexpectedUniFFICallbackError instead of meaningful error messages. Changes: - Add ConnectException handler to map connection failures to HttpError - Add catch-all Exception handler to map unexpected errors to GenericError - Add testLocalSite integration test to verify localhost API discovery works
crazytonyli
approved these changes
Nov 17, 2025
Suppress TooGenericExceptionCaught and SwallowedException warnings in the request executor. These are intentional design choices to ensure all network exceptions are properly converted to Rust error types instead of crashing the UniFFI callback layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes exception handling in the Kotlin request executor to prevent
UnexpectedUniFFICallbackErrorcrashes. The executor now properly catches and maps all network exceptions (includingConnectException) to appropriate Rust error types instead of letting them propagate uncaught through the UniFFI callback layer.Changes
ConnectExceptionhandler mapping toHttpErrorExceptionhandler mapping toGenericError