Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed on Slack, it seems

/users
endpoint doesn't always return theavatar_urls
field as promised in the documentation.Unfortunately, I haven't foreseen the possibility of adding
Option<T>
to our generated contextual types such asUserWithEditContext
when I worked onwp_contextual
. This PR adds a new field attributeWPContextualOption
which will leave the type of the field as is - without any modification. Just as a reminder, withWPContext
andWPContextualField
attributes, the type was always modified. (by removing theOption
wrapper &Sparse
prefix respectively)This new attribute should be used alongside
WPContext
as without it, the field wouldn't be included in the contextual type in the first place. It also can not be used withWPContextualField
because whileWPContextualField
will remove theSparse
prefix from the type,WPContextualOption
will leave it as-is. So, they are incompatible.All these cases are handled with proper errors, and integration tested. The documentation is also updated.
Before reviewing the implementation, I suggest taking a look at the new integration tests and the documentation to better understand the changes.
To Test
make test-server && make dump-mysql && make backup-wp-content-plugins
cargo test --test '*' -- --nocapture --test-threads 1